No chrome dependencies in TemplateURLFetcher and TemplateURLParser

No chrome dependencies in TemplateURLFetcher and TemplateURLParser

Pass SearchTermsData and URLRequestContextGetter to TemplateURLFetcher instead of Profile.
Replace TemplateURLFetcherCallbacks with base::Callback.

BUG=371535
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281661

[Peter Kasting, 2014-07-07 22:48:44]

LGTM

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_fetcher.h (right):

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_fetcher.h:80: 
Nit: Unnecessary blank line

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/ui/search...
File chrome/browser/ui/search_engines/search_engine_tab_helper.cc (right):

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/ui/search...
chrome/browser/ui/search_engines/search_engine_tab_helper.cc:147:
delegate_->ConfirmAddSearchProvider(template_url.release(), profile);
Bonus points if in some future change you make ConfirmAddSearchProvider() take a
scoped_ptr as its first arg instead of a raw pointer.

[hashimoto, 2014-07-08 00:19:36]

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_fetcher.h (right):

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_fetcher.h:80: 
On 2014/07/07 22:48:44, Peter Kasting wrote:
> Nit: Unnecessary blank line

Done.

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/ui/search...
File chrome/browser/ui/search_engines/search_engine_tab_helper.cc (right):

https://codereview.chromium.org/367413003/diff/60001/chrome/browser/ui/search...
chrome/browser/ui/search_engines/search_engine_tab_helper.cc:147:
delegate_->ConfirmAddSearchProvider(template_url.release(), profile);
On 2014/07/07 22:48:44, Peter Kasting wrote:
> Bonus points if in some future change you make ConfirmAddSearchProvider() take
a
> scoped_ptr as its first arg instead of a raw pointer.
That should be nice.
I'll do it later.

[hashimoto, 2014-07-08 00:21:44]

TBRing isherman@chromium.org for argument change in
chrome/browser/importer/in_process_importer_bridge.cc

[Ilya Sherman, 2014-07-08 00:33:25]

chrome/browser/importer/in_process_importer_bridge.cc LGTM

[hashimoto, 2014-07-08 00:39:49]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-07-08 00:42:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/367413003/80001

[commit-bot: I haz the power, 2014-07-08 03:17:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[commit-bot: I haz the power, 2014-07-08 04:28:57]

Change committed as 281661