Add missing Pass() calls for passing scoped_ptrs on Windows.

chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc

Index: chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc
diff --git a/chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc b/chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc
index d302690acfaf55f94ad90a876e83d9b623a7d838..dc99fd2f590409f0b82ab8b2961a17a575de0776 100644
--- a/chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc
+++ b/chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc
@@ -135,7 +135,7 @@ TEST(StatusTrayWinTest, EnsureVisibleTest) {
 
   FakeStatusTrayStateChangerProxy* proxy =
       new FakeStatusTrayStateChangerProxy();
-  tray.SetStatusTrayStateChangerProxyForTest(make_scoped_ptr(proxy));
+  tray.SetStatusTrayStateChangerProxyForTest(make_scoped_ptr(proxy).Pass());

[grt (UTC plus 2), 2014/07/04 01:32:28]

since SetStatusTrayStateChangerProxyForTest takes a
scoped_ptr<StatusTrayStateChangerProxy>, doesn't this need to be either:
  make_scoped_ptr(proxy).PassAs<StatusTrayStateChangerProxy>()
or:
  scoped_ptr<StatusTrayStateChangerProxy>(proxy)?
for what it's worth, i prefer the latter since it's shorter.

ah, i now see that you've done the same thing elsewhere, so i suppose that what
you have works. i find make_scoped_ptr(instanceOfDerivedType).Pass() odd, so i
would prefer that you replace it with
scoped_ptr<RealType>(instanceOfDerivedType) here and elsewhere since it's more
explicit and less magical.

note that i have not consulted the rest of the codebase to see if what you have
here is actually more idomatic than what i propose. if that's the case, then
this will be my "today i learned...".

cheers

[Nico, 2014/07/04 02:20:12]

Yes, you're right. Done.

(Actually, I made proxy a scoped_ptr<StatusTrayStateChangerProxy> and then Pass
that, as I think the idea is that there should rarely be raw pointers that are
strong.)
This CL was written without a local clang build, so it's possible I didn't do
everything right. I went through it again and tried to find all the other places
where I got this wrong, thanks. (Mostly using your preferred approach.)

I left the places where it says make_scoped_ptr(foo).PassAs<subtype>()
correctly. I'm not sure which form is preferred; maybe Albert has an opinion.
The PassAs docs only talk about local variables, not about make_scoped_ptr
calls.

[Nico, 2014/07/04 04:20:52]

…except that that doesn't build, since this test accesses proxy after it's been
passed. That seems…unfortunate. I added a comment that explains why it's fine,
and went with the method you proposed here.

 
   StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon(
       StatusTray::OTHER_ICON, *image, base::ASCIIToUTF16("tool tip")));