Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/installer/util/google_chrome_distribution_dummy.cc

Issue 367403002: Add missing Pass() calls for passing scoped_ptrs on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: :-( Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines dummy implementation of several functions from the 5 // This file defines dummy implementation of several functions from the
6 // BrowserDistribution class for Google Chrome. These functions allow 64-bit 6 // BrowserDistribution class for Google Chrome. These functions allow 64-bit
7 // Windows Chrome binary to build successfully. Since this binary is only used 7 // Windows Chrome binary to build successfully. Since this binary is only used
8 // for Native Client support, most of the install/uninstall functionality is not 8 // for Native Client support, most of the install/uninstall functionality is not
9 // necessary there. 9 // necessary there.
10 10
11 #include "chrome/installer/util/google_chrome_distribution.h" 11 #include "chrome/installer/util/google_chrome_distribution.h"
12 12
13 #include <windows.h> 13 #include <windows.h>
14 14
15 #include "base/files/file_path.h" 15 #include "base/files/file_path.h"
16 #include "base/logging.h" 16 #include "base/logging.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "chrome/installer/util/app_registration_data.h" 18 #include "chrome/installer/util/app_registration_data.h"
19 #include "chrome/installer/util/non_updating_app_registration_data.h" 19 #include "chrome/installer/util/non_updating_app_registration_data.h"
20 20
21 GoogleChromeDistribution::GoogleChromeDistribution() 21 GoogleChromeDistribution::GoogleChromeDistribution()
22 : BrowserDistribution(CHROME_BROWSER, 22 : BrowserDistribution(
23 make_scoped_ptr( 23 CHROME_BROWSER,
24 scoped_ptr<AppRegistrationData>(
24 new NonUpdatingAppRegistrationData(base::string16()))) { 25 new NonUpdatingAppRegistrationData(base::string16()))) {
25 } 26 }
26 27
27 GoogleChromeDistribution::GoogleChromeDistribution( 28 GoogleChromeDistribution::GoogleChromeDistribution(
28 scoped_ptr<AppRegistrationData> app_reg_data) 29 scoped_ptr<AppRegistrationData> app_reg_data)
29 : BrowserDistribution(CHROME_BROWSER, app_reg_data.Pass()) { 30 : BrowserDistribution(CHROME_BROWSER, app_reg_data.Pass()) {
30 } 31 }
31 32
32 void GoogleChromeDistribution::DoPostUninstallOperations( 33 void GoogleChromeDistribution::DoPostUninstallOperations(
33 const Version& version, 34 const Version& version,
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 installer::InstallStatus install_status) { 115 installer::InstallStatus install_status) {
115 } 116 }
116 117
117 bool GoogleChromeDistribution::ShouldSetExperimentLabels() { 118 bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
118 return false; 119 return false;
119 } 120 }
120 121
121 bool GoogleChromeDistribution::HasUserExperiments() { 122 bool GoogleChromeDistribution::HasUserExperiments() {
122 return false; 123 return false;
123 } 124 }
OLDNEW
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.cc ('k') | chrome/installer/util/google_chrome_sxs_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698