Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/installer/util/chromium_binaries_distribution.cc

Issue 367403002: Add missing Pass() calls for passing scoped_ptrs on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares a class that contains various method related to branding. 5 // This file declares a class that contains various method related to branding.
6 6
7 #include "chrome/installer/util/google_chrome_binaries_distribution.h" 7 #include "chrome/installer/util/google_chrome_binaries_distribution.h"
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/installer/util/app_registration_data.h" 10 #include "chrome/installer/util/app_registration_data.h"
11 #include "chrome/installer/util/non_updating_app_registration_data.h" 11 #include "chrome/installer/util/non_updating_app_registration_data.h"
12 12
13 namespace { 13 namespace {
14 14
15 const wchar_t kChromiumBinariesName[] = L"Chromium Binaries"; 15 const wchar_t kChromiumBinariesName[] = L"Chromium Binaries";
16 16
17 } // namespace 17 } // namespace
18 18
19 ChromiumBinariesDistribution::ChromiumBinariesDistribution() 19 ChromiumBinariesDistribution::ChromiumBinariesDistribution()
20 : BrowserDistribution(CHROME_BINARIES, 20 : BrowserDistribution(
21 CHROME_BINARIES,
21 make_scoped_ptr(new NonUpdatingAppRegistrationData( 22 make_scoped_ptr(new NonUpdatingAppRegistrationData(
22 base::string16(L"Software\\").append(kChromiumBinariesName)))), 23 base::string16(L"Software\\")
24 .append(kChromiumBinariesName))).Pass()),
23 browser_distribution_( 25 browser_distribution_(
24 BrowserDistribution::GetSpecificDistribution(CHROME_BROWSER)) { 26 BrowserDistribution::GetSpecificDistribution(CHROME_BROWSER)) {
25 } 27 }
26 28
27 ChromiumBinariesDistribution::ChromiumBinariesDistribution( 29 ChromiumBinariesDistribution::ChromiumBinariesDistribution(
28 scoped_ptr<AppRegistrationData> app_reg_data) 30 scoped_ptr<AppRegistrationData> app_reg_data)
29 : BrowserDistribution(CHROME_BINARIES, app_reg_data.Pass()), 31 : BrowserDistribution(CHROME_BINARIES, app_reg_data.Pass()),
30 browser_distribution_( 32 browser_distribution_(
31 BrowserDistribution::GetSpecificDistribution(CHROME_BROWSER)) { 33 BrowserDistribution::GetSpecificDistribution(CHROME_BROWSER)) {
32 } 34 }
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 109
108 bool ChromiumBinariesDistribution::GetChromeChannel(base::string16* channel) { 110 bool ChromiumBinariesDistribution::GetChromeChannel(base::string16* channel) {
109 NOTREACHED(); 111 NOTREACHED();
110 return false; 112 return false;
111 } 113 }
112 114
113 bool ChromiumBinariesDistribution::GetCommandExecuteImplClsid( 115 bool ChromiumBinariesDistribution::GetCommandExecuteImplClsid(
114 base::string16* handler_class_uuid) { 116 base::string16* handler_class_uuid) {
115 return false; 117 return false;
116 } 118 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698