Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 367373008: rendering_helper - Unbind the thumbnail texture. (Closed)

Created:
6 years, 5 months ago by Owen Lin
Modified:
6 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

rendering_helper - Unbind the thumbnail texture. Otherwise, before the ActiveTexture0 binding to other texture, the thumbnail texture will be blended with other decoded frames. This can be observed with low rendering fps on ARM CrOS device. BUG=None TEST=Run the vda_unittest on arm cros device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/common/gpu/media/rendering_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Owen Lin
PTAL. Thanks.
6 years, 5 months ago (2014-07-07 04:02:17 UTC) #1
Pawel Osciak
lgtm
6 years, 5 months ago (2014-07-07 04:15:03 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 5 months ago (2014-07-07 19:16:53 UTC) #3
Owen Lin
The CQ bit was checked by owenlin@chromium.org
6 years, 5 months ago (2014-07-08 07:31:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/367373008/1
6 years, 5 months ago (2014-07-08 07:31:59 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 13:13:19 UTC) #6
Message was sent while issue was closed.
Change committed as 281735

Powered by Google App Engine
This is Rietveld 408576698