Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: src/hydrogen.h

Issue 367343002: Hydrogenized KeyedLoadGeneric stub: when probing the KeyedLookupCache fails, call the runtime, don'… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: check for valid builder Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index 2a899b921415dc0a9ca35fe86db5b960c1ac0af8..a49fef72007013a745049b5e387daad99e724684 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1475,6 +1475,9 @@ class HGraphBuilder {
class IfBuilder V8_FINAL {
public:
+ // If using this constructor, Initialize() must be called explicitly!
+ IfBuilder();
+
explicit IfBuilder(HGraphBuilder* builder);
IfBuilder(HGraphBuilder* builder,
HIfContinuation* continuation);
@@ -1483,6 +1486,8 @@ class HGraphBuilder {
if (!finished_) End();
}
+ void Initialize(HGraphBuilder* builder);
+
template<class Condition>
Condition* If(HValue *p) {
Condition* compare = builder()->New<Condition>(p);
@@ -1625,9 +1630,14 @@ class HGraphBuilder {
void Return(HValue* value);
private:
+ void InitializeDontCreateBlocks(HGraphBuilder* builder);
+
HControlInstruction* AddCompare(HControlInstruction* compare);
- HGraphBuilder* builder() const { return builder_; }
+ HGraphBuilder* builder() const {
+ ASSERT(builder_ != NULL); // Have you called "Initialize"?
+ return builder_;
+ }
void AddMergeAtJoinBlock(bool deopt);
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698