|
|
Created:
7 years, 2 months ago by wolanski Modified:
7 years, 1 month ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionAdding name to AUTHORS list
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233692
Patch Set 1 #Messages
Total messages: 16 (0 generated)
My understanding is samsung has signed the CCLA, so as long as you also have a patch to be AUTHOR of, then this is LGTM. http://www.chromium.org/developers/contributing-code
On 2013/10/24 20:20:26, eseidel wrote: > My understanding is samsung has signed the CCLA, so as long as you also have a > patch to be AUTHOR of, then this is LGTM. > > http://www.chromium.org/developers/contributing-code To be clear, we (Samsung) do not have a blanket CLA. We have a CLA with specific samsung emails added to it. So a googler still needs to check that k.wolanski's email was added to our CLA.
Confirmed. k.wolanski@samsung.com - Krzysztof Wolanski
On 2013/10/24 20:29:56, eseidel wrote: > Confirmed. > > mailto:k.wolanski@samsung.com - Krzysztof Wolanski Thanks
On 2013/10/24 20:20:26, eseidel wrote: > My understanding is samsung has signed the CCLA, so as long as you also have a > patch to be AUTHOR of, then this is LGTM. > > http://www.chromium.org/developers/contributing-code I have a patch under review: https://codereview.chromium.org/27169003/
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.wolanski@samsung.com/36733002/1
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.wolanski@samsung.com/36733002/1
Step "update" is always a major failure. Look at the try server FAQ for more details. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.wolanski@samsung.com/36733002/1
Message was sent while issue was closed.
Change committed as 233692 |