Issue 367323003: Revert of Caching the result of readPixelsSupported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367323003: Revert of Caching the result of readPixelsSupported (Closed)

Created:
6 years, 5 months ago by reed2

Modified:
6 years, 5 months ago

Reviewers:
Rémi Piotaix, Justin Novosad

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Caching the result of readPixelsSupported (https://codereview.chromium.org/364193004/) Reason for revert: appears to crash GM on Ubuntu and Win8 http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/1237/steps/GenerateGMs/logs/stdio Original issue's description: > Caching the result of readPixelsSupported > > The call was calling GR_GL_GetIntegerv 2 times for each readPixels > and thus was causing a loss of performance > > (resubmit of issue 344793008) > > Benchmark url: http://packages.gkny.fr/tst/index.html > > BUG=skia:2681 > > Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c TBR=junov@chromium.org,piotaixr@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2681 Committed: https://skia.googlesource.com/skia/+/2fe7b466c15fab6593da3bf32d3c3dbdf3917c01

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -82 lines)			Patch
M	src/gpu/gl/GrGLCaps.h	View	4 chunks	+1 line, -39 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	4 chunks	+2 lines, -35 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	3 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of Caching the result of readPixelsSupported

6 years, 5 months ago (2014-07-03 14:53:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/367323003/1

6 years, 5 months ago (2014-07-03 14:54:00 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-03 14:54:12 UTC) #3

Message was sent while issue was closed.

Change committed as 2fe7b466c15fab6593da3bf32d3c3dbdf3917c01