Add SVG icon example to key_silk_cases

Add SVG icon example to key_silk_cases

I'm only 50% sure I got everything right when adding the WPR archive etc, so any guidance appreciated.

BUG=391197
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281687

[wiltzius, 2014-07-04 03:46:38]

On 2014/07/04 03:44:58, wiltzius wrote:

Adding Sami for an OWNERS review since everyone in the US is on holiday

[Sami, 2014-07-04 09:35:31]

lgtm as far as I can tell. We should probably fix the recording script to keep
the wpr sorted to make these diffs a little more manageable.

[nduca, 2014-07-07 17:12:35]

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.py:589: action_runner.Wait(1)
it'd be awesome if, on all the demos that use webanim, we can use
WaitForJavascriptExpression(...) so that we dont have hard coded waits... i get
that this isn't that case so ~shrug~ lgtm

[nednguyen, 2014-07-07 18:10:01]

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.py:583: for i in range(9):
nit: maybe xrange(9) instead?

[dtu, 2014-07-07 22:51:52]

lgtm

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.py:567: class Page27(KeySilkCasesPage):
nit: think we'd like to start giving these useful names.

[wiltzius, 2014-07-08 04:20:56]

Thanks everyone!

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.py:567: class Page27(KeySilkCasesPage):
On 2014/07/07 22:51:52, dtu wrote:
> nit: think we'd like to start giving these useful names.

Done.

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.py:583: for i in range(9):
On 2014/07/07 18:10:01, nednguyen wrote:
> nit: maybe xrange(9) instead? 

Done.

https://codereview.chromium.org/367283002/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.py:589: action_runner.Wait(1)
On 2014/07/07 17:12:35, nduca wrote:
> it'd be awesome if, on all the demos that use webanim, we can use
> WaitForJavascriptExpression(...) so that we dont have hard coded waits... i
get
> that this isn't that case so ~shrug~ lgtm

Will do for future examples. This one doesn't use WebAnim; I tried retrofitting
transitionEnd events onto it and it works, but it ends up being a bunch of code
that's more fragile (since you're carefully counting events) than just waiting
for the transition.

[wiltzius, 2014-07-08 04:21:05]

The CQ bit was checked by wiltzius@chromium.org

[commit-bot: I haz the power, 2014-07-08 04:22:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wiltzius@chromium.org/367283002/20001

[commit-bot: I haz the power, 2014-07-08 06:19:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-08 07:29:07]

Change committed as 281687