Issue 367263005: Revert of Added touch event permutations test to touch_exploration_controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367263005: Revert of Added touch event permutations test to touch_exploration_controller. (Closed)

Created:
6 years, 5 months ago by Nikita (slow)

Modified:
6 years, 5 months ago

Reviewers:
dmazzoni, aboxhall, evy

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, lisayin

Base URL:
https://chromium.googlesource.com/chromium/src.git@new_passthrough

Project:
chromium

Visibility:
Public.

Revert of Added touch event permutations test to touch_exploration_controller. (https://codereview.chromium.org/358693004/) Reason for revert: New test is failing on Linux ChromiumOS Tests (dbg) http://goo.gl/rwFMMz Original issue's description: > Added touch event permutations test to touch_exploration_controller. > All permutations of three fingers pressing, moving, and releasing are now being tested. Fingers that were recorded as pressed during the permutation but not released yet are released, and then there is a check for no fingers down. > > BUG=388520 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281195 TBR=dmazzoni@chromium.org,aboxhall@chromium.org,evy@chromium.org NOTREECHECKS=true NOTRY=true BUG=388520 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281235

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -166 lines)			Patch
M	ui/chromeos/touch_exploration_controller.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/chromeos/touch_exploration_controller.cc	View	15 chunks	+14 lines, -32 lines	0 comments	Download
M	ui/chromeos/touch_exploration_controller_unittest.cc	View	5 chunks	+1 line, -127 lines	0 comments	Download

Total messages: 3 (0 generated)

Nikita (slow)

Created Revert of Added touch event permutations test to touch_exploration_controller.

6 years, 5 months ago (2014-07-03 11:47:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/367263005/1

6 years, 5 months ago (2014-07-03 11:48:01 UTC) #2

Message was sent while issue was closed.

Change committed as 281235