cc/trees/layer_tree_host_impl.cc - Issue 367173003: [Android] Implementation of overscroll effect for Android L

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 367173003: [Android] Implementation of overscroll effect for Android L (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_impl.cc

diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc

index 2845d1897950097b67ee075b27d4daa630a24923..705598b012778841dd32762fdd1851d8ee4e61f0 100644

--- a/cc/trees/layer_tree_host_impl.cc

+++ b/cc/trees/layer_tree_host_impl.cc

@@ -2672,8 +2672,8 @@ bool LayerTreeHostImpl::ScrollBy(const gfx::Point& viewport_point,

accumulated_root_overscroll_ += unused_root_delta;

bool did_overscroll = !unused_root_delta.IsZero();

if (did_overscroll && input_handler_client_) {

- input_handler_client_->DidOverscroll(accumulated_root_overscroll_,

- unused_root_delta);

+ input_handler_client_->DidOverscroll(

+ viewport_point, accumulated_root_overscroll_, unused_root_delta);

}

return did_scroll_content || did_scroll_top_controls;

@@ -3297,7 +3297,7 @@ void LayerTreeHostImpl::CreateUIResource(UIResourceId uid,

case UIResourceBitmap::ETC1:

format = ETC1;

break;

- };

+ }

id = resource_provider_->CreateResource(

bitmap.GetSize(),

wrap_mode,

« no previous file with comments | « cc/input/input_handler.h ('k') | cc/trees/layer_tree_host_unittest_scroll.cc » ('j') | no next file with comments »