Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 367163003: Disallow squashing for layers with reflections (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
chrishtr, esprehn
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, Rik, danakj, krit, eae+blinkwatch, esprehn, jamesr, jbroman, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, Stephen Chennney, Ian Vollick, zoltan1
Project:
blink
Visibility:
Public.

Description

Disallow squashing for layers with reflections We're not smart enough to draw reflections into squashing layers. Instead, these layers need to be separately composited so we can set up the reflection layer correctly. BUG=391022 R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177432

Patch Set 1 #

Patch Set 2 : Use blue.png instead of ducky.png #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -34 lines) Patch
A LayoutTests/compositing/squashing/squashing-reflection-disallowed.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/squashing-reflection-disallowed-expected.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositingLayerAssigner.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M Source/platform/graphics/CompositingReasons.h View 5 chunks +36 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
6 years, 5 months ago (2014-07-02 21:26:00 UTC) #1
esprehn
lgtm
6 years, 5 months ago (2014-07-02 21:28:05 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-02 21:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/367163003/1
6 years, 5 months ago (2014-07-02 21:39:16 UTC) #4
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 5 months ago (2014-07-02 21:39:34 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-02 21:47:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/367163003/20001
6 years, 5 months ago (2014-07-02 21:47:17 UTC) #7
chrishtr
lgtm
6 years, 5 months ago (2014-07-02 22:01:28 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 22:51:48 UTC) #9
Message was sent while issue was closed.
Change committed as 177432

Powered by Google App Engine
This is Rietveld 408576698