chrome/browser/sync/profile_sync_service_factory.cc - Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_factory.cc

Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed scoped_ptr issue in ProfileSyncService constructor Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_service_factory.cc

diff --git a/chrome/browser/sync/profile_sync_service_factory.cc b/chrome/browser/sync/profile_sync_service_factory.cc

index 6b5ae2b03d6ccd26560fa30db5ca037f048fe15e..6ac4cf92df549149761c296852e443ae3e1d5229 100644

--- a/chrome/browser/sync/profile_sync_service_factory.cc

+++ b/chrome/browser/sync/profile_sync_service_factory.cc

@@ -129,11 +129,13 @@ KeyedService* ProfileSyncServiceFactory::BuildServiceInstanceFor(

browser_defaults::kSyncAutoStarts ? browser_sync::AUTO_START

: browser_sync::MANUAL_START;

ProfileSyncService* pss = new ProfileSyncService(

- new ProfileSyncComponentsFactoryImpl(profile,

- CommandLine::ForCurrentProcess(),

- sync_service_url,

- token_service,

- url_request_context_getter),

+ scoped_ptr<ProfileSyncComponentsFactory>(

+ new ProfileSyncComponentsFactoryImpl(

+ profile,

+ CommandLine::ForCurrentProcess(),

+ sync_service_url,

+ token_service,

+ url_request_context_getter)),

profile,

signin_wrapper.Pass(),

token_service,

« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/sync/profile_sync_service_mock.h » ('j') | no next file with comments »