chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc - Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed scoped_ptr issue in ProfileSyncService constructor Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.cc ('k') | chrome/browser/sync/profile_sync_components_factory_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc b/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

index ea0b1d9f953e980f0ebd04366cabacc4081e2f8d..f016ae4015c992353b7dca95efb47b5dc87c31d8 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

@@ -106,12 +106,13 @@ class ProfileSyncComponentsFactoryImplTest : public testing::Test {

ProfileOAuth2TokenService* token_service =

ProfileOAuth2TokenServiceFactory::GetForProfile(profile_.get());

scoped_ptr<ProfileSyncService> pss(new ProfileSyncService(

- new ProfileSyncComponentsFactoryImpl(

- profile_.get(),

- command_line_.get(),

- ProfileSyncService::GetSyncServiceURL(*command_line_),

- token_service,

- profile_->GetRequestContext()),

+ scoped_ptr<ProfileSyncComponentsFactory>(

+ new ProfileSyncComponentsFactoryImpl(

+ profile_.get(),

+ command_line_.get(),

+ ProfileSyncService::GetSyncServiceURL(*command_line_),

+ token_service,

+ profile_->GetRequestContext())),

profile_.get(),

make_scoped_ptr<SupervisedUserSigninManagerWrapper>(NULL),

token_service,

@@ -133,12 +134,13 @@ TEST_F(ProfileSyncComponentsFactoryImplTest, CreatePSSDefault) {