Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3481)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test issues with mocking of LocalDeviceInfoProvider Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
index 56be45208210745f3ad93ca5b865fca6d16f5c5e..7ff873af253ed0d2ee54c16560b2e82a6ef8cdf2 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/sessions/session_types.h"
#include "chrome/browser/sessions/persistent_tab_restore_service.h"
#include "chrome/browser/sessions/tab_restore_service_factory.h"
+#include "chrome/browser/sync/glue/local_device_info_provider_mock.h"
#include "chrome/browser/sync/glue/synced_session.h"
#include "chrome/browser/sync/profile_sync_service_mock.h"
#include "chrome/browser/sync/sessions/sessions_sync_manager.h"
@@ -109,14 +110,19 @@ class DummyRouter : public browser_sync::LocalSessionEventRouter {
} // namespace
class RecentTabsSubMenuModelTest
- : public BrowserWithTestWindowTest,
- public browser_sync::SessionsSyncManager::SyncInternalApiDelegate {
+ : public BrowserWithTestWindowTest {
public:
RecentTabsSubMenuModelTest()
: sync_service_(&testing_profile_) {
+ local_device_.reset(new browser_sync::LocalDeviceInfoProviderMock(
sky 2014/07/14 19:33:34 move to member initializer list.
stanisc 2014/07/14 22:49:05 Done.
+ "RecentTabsSubMenuModelTest",
+ "Test Machine",
+ "Chromium 10k",
+ "Chrome 10k",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX));
manager_.reset(new browser_sync::SessionsSyncManager(
&testing_profile_,
- this,
+ local_device_.get(),
scoped_ptr<browser_sync::LocalSessionEventRouter>(
new DummyRouter())));
manager_->MergeDataAndStartSyncing(
@@ -141,7 +147,6 @@ class RecentTabsSubMenuModelTest
Profile::FromBrowserContext(browser_context), NULL);
}
-
browser_sync::OpenTabsUIDelegate* GetOpenTabsDelegate() {
return manager_.get();
}
@@ -150,25 +155,12 @@ class RecentTabsSubMenuModelTest
helper->ExportToSessionsSyncManager(manager_.get());
}
- virtual scoped_ptr<browser_sync::DeviceInfo> GetLocalDeviceInfo()
- const OVERRIDE {
- return scoped_ptr<browser_sync::DeviceInfo>(
- new browser_sync::DeviceInfo(GetLocalSyncCacheGUID(),
- "Test Machine",
- "Chromium 10k",
- "Chrome 10k",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX));
- }
-
- virtual std::string GetLocalSyncCacheGUID() const OVERRIDE {
- return "RecentTabsSubMenuModelTest";
- }
-
private:
TestingProfile testing_profile_;
testing::NiceMock<ProfileSyncServiceMock> sync_service_;
scoped_ptr<browser_sync::SessionsSyncManager> manager_;
+ scoped_ptr<browser_sync::LocalDeviceInfoProviderMock> local_device_;
};
// Test disabled "Recently closed" header with no foreign tabs.

Powered by Google App Engine
This is Rietveld 408576698