Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm

Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test issues with mocking of LocalDeviceInfoProvider Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
index 774b5597c7ca28cd4efcd36a9937a57572073685..0a34b0d52080db8dafe70414840fd0b4cb66492b 100644
--- a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
@@ -8,6 +8,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/sync/glue/device_info.h"
+#include "chrome/browser/sync/glue/local_device_info_provider_mock.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/sync/sessions/sessions_sync_manager.h"
#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
@@ -57,9 +58,18 @@ class DummyRouter : public browser_sync::LocalSessionEventRouter {
};
class WrenchMenuControllerTest
- : public CocoaProfileTest,
- public browser_sync::SessionsSyncManager::SyncInternalApiDelegate {
+ : public CocoaProfileTest {
public:
+ WrenchMenuControllerTest() {
+ local_device_.reset(new browser_sync::LocalDeviceInfoProviderMock(
sky 2014/07/14 19:33:34 nit: make part of member initialize list.
stanisc 2014/07/14 22:49:05 Done.
+ "WrenchMenuControllerTest",
+ "Test Machine",
+ "Chromium 10k",
+ "Chrome 10k",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX));
+ }
+ virtual ~WrenchMenuControllerTest() {}
+
virtual void SetUp() OVERRIDE {
CocoaProfileTest::SetUp();
ASSERT_TRUE(browser());
@@ -69,7 +79,7 @@ class WrenchMenuControllerTest
manager_.reset(new browser_sync::SessionsSyncManager(
profile(),
- this,
+ local_device_.get(),
scoped_ptr<browser_sync::LocalSessionEventRouter>(
new DummyRouter())));
manager_->MergeDataAndStartSyncing(
@@ -81,20 +91,6 @@ class WrenchMenuControllerTest
new syncer::SyncErrorFactoryMock));
}
- virtual scoped_ptr<browser_sync::DeviceInfo> GetLocalDeviceInfo()
- const OVERRIDE {
- return scoped_ptr<browser_sync::DeviceInfo>(
- new browser_sync::DeviceInfo(GetLocalSyncCacheGUID(),
- "Test Machine",
- "Chromium 10k",
- "Chrome 10k",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX));
- }
-
- virtual std::string GetLocalSyncCacheGUID() const OVERRIDE {
- return "WrenchMenuControllerTest";
- }
-
void RegisterRecentTabs(RecentTabsBuilderTestHelper* helper) {
helper->ExportToSessionsSyncManager(manager_.get());
}
@@ -120,6 +116,7 @@ class WrenchMenuControllerTest
private:
scoped_ptr<browser_sync::SessionsSyncManager> manager_;
+ scoped_ptr<browser_sync::LocalDeviceInfoProviderMock> local_device_;
};
TEST_F(WrenchMenuControllerTest, Initialized) {

Powered by Google App Engine
This is Rietveld 408576698