chrome/browser/sync/profile_sync_components_factory.h - Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory.h

Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test issues with mocking of LocalDeviceInfoProvider Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc ('K') | « chrome/browser/sync/glue/sync_backend_host_mock.cc ('k') | chrome/browser/sync/profile_sync_components_factory_impl.h » ('j') | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory.h

diff --git a/chrome/browser/sync/profile_sync_components_factory.h b/chrome/browser/sync/profile_sync_components_factory.h

index cad9b0ba318cb4d81923b5adb4bbf0ffb8f85365..bab09da1ea736a98e194c234f117de48862f7c30 100644

--- a/chrome/browser/sync/profile_sync_components_factory.h

+++ b/chrome/browser/sync/profile_sync_components_factory.h

@@ -30,6 +30,7 @@ class DataTypeManager;

class DataTypeManagerObserver;

class FailedDataTypesHandler;

class GenericChangeProcessor;

+class LocalDeviceInfoProvider;

class SyncBackendHost;

class DataTypeErrorHandler;

} // namespace browser_sync

@@ -98,6 +99,10 @@ class ProfileSyncComponentsFactory

const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs,

const base::FilePath& sync_folder) = 0;

+ // Creating this in the factory helps us mock it out in testing.

+ virtual scoped_ptr<browser_sync::LocalDeviceInfoProvider>

+ CreateLocalDeviceInfoProvider() = 0;

// Legacy datatypes that need to be converted to the SyncableService API.

virtual SyncComponents CreateBookmarkSyncComponents(

ProfileSyncService* profile_sync_service,