chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc - Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

Issue 367153005: Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test issues with mocking of LocalDeviceInfoProvider Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc ('K') | « chrome/browser/sync/glue/local_device_info_provider_unittest.cc ('k') | chrome/browser/sync/glue/sync_backend_host_core.cc » ('j') | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

diff --git a/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc b/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

index 7a44748e9b3f9045a836b026729875de9afb8f78..5488548c3ac9a987d1758b0730b3b98dab18510c 100644

--- a/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

+++ b/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

@@ -120,8 +120,7 @@ class SyncNonFrontendDataTypeControllerTest : public testing::Test {

virtual void SetUp() {

db_thread_.Start();

- profile_sync_factory_.reset(

- new StrictMock<ProfileSyncComponentsFactoryMock>());

+ profile_sync_factory_.reset(new ProfileSyncComponentsFactoryMock());

// All of these are refcounted, so don't need to be released.

dtc_mock_ = new StrictMock<NonFrontendDataTypeControllerMock>();