Sync: Refactoring of DEVICE_INFO syncable type - Part 1

chrome/browser/sync/glue/local_device_info_provider_mock.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_GLUE_LOCAL_DEVICE_INFO_PROVIDER_MOCK_H_
+#define CHROME_BROWSER_SYNC_GLUE_LOCAL_DEVICE_INFO_PROVIDER_MOCK_H_
+
+#include "chrome/browser/sync/glue/device_info.h"
+#include "chrome/browser/sync/glue/local_device_info_provider.h"
+
+namespace browser_sync {
+
+class LocalDeviceInfoProviderMock : public LocalDeviceInfoProvider {

[maniscalco, 2014/07/08 21:17:53]

Most of the sync code I've seen prefixes mocks with Mock (e.g.
MockLocalDeviceProvider).

[stanisc, 2014/07/09 21:58:36]

There are 26 instances (including this one) of files with _mock suffix. Many of
them are in Sync code including ProfileSyncServiceMock and
ProfileSyncComponentsFactoryMock. I agree that having Mock as a prefix would
make a better name, but having it as a suffix makes it easier to group related
files together and it kind of follows the pattern of adding other suffixes like
Impl or Test. I'd prefer to leave it this way unless you think we should start
renaming all of these mock classes.
 

[maniscalco, 2014/07/09 22:47:34]

You're right, it's mixed.  All of the files in c/b/sync end with _mock whereas
(almost all of) those in src/sync start with mock_:

maniscalco-z620 ~/chromium/src(master) $ find chrome/browser/sync | grep mock
chrome/browser/sync/profile_sync_service_mock.cc
chrome/browser/sync/glue/sync_backend_host_mock.cc
chrome/browser/sync/glue/sync_backend_host_mock.h
chrome/browser/sync/glue/non_frontend_data_type_controller_mock.h
chrome/browser/sync/glue/frontend_data_type_controller_mock.cc
chrome/browser/sync/glue/non_frontend_data_type_controller_mock.cc
chrome/browser/sync/glue/frontend_data_type_controller_mock.h
chrome/browser/sync/profile_sync_components_factory_mock.cc
chrome/browser/sync/profile_sync_service_mock.h
chrome/browser/sync/profile_sync_components_factory_mock.h

maniscalco-z620 ~/chromium/src(master) $ find sync | grep mock
sync/notifier/mock_ack_handler.h
sync/notifier/mock_ack_handler.cc
sync/test/mock_invalidation.h
sync/test/engine/mock_connection_manager.h
sync/test/engine/mock_model_type_sync_proxy.cc
sync/test/engine/mock_update_handler.cc
sync/test/engine/mock_model_type_sync_proxy.h
sync/test/engine/mock_update_handler.h
sync/test/engine/single_type_mock_server.cc
sync/test/engine/single_type_mock_server.h
sync/test/engine/mock_model_type_sync_worker.cc
sync/test/engine/mock_connection_manager.cc
sync/test/engine/mock_model_type_sync_worker.h
sync/test/sessions/mock_debug_info_getter.h
sync/test/sessions/mock_debug_info_getter.cc
sync/test/trackable_mock_invalidation.cc
sync/test/trackable_mock_invalidation.h
sync/test/mock_invalidation.cc
sync/test/mock_invalidation_tracker.cc
sync/test/mock_invalidation_tracker.h
sync/api/sync_error_factory_mock.h
sync/api/sync_error_factory_mock.cc

I agree on leaving as is.

On 2014/07/09 21:58:36, stanisc wrote:

+ public:
+  LocalDeviceInfoProviderMock(
+      const std::string& guid,
+      const std::string& client_name,
+      const std::string& chrome_version,
+      const std::string& sync_user_agent,
+      const sync_pb::SyncEnums::DeviceType device_type);
+  virtual ~LocalDeviceInfoProviderMock();
+
+  virtual const DeviceInfo* GetLocalDeviceInfo() const OVERRIDE;
+  virtual std::string GetLocalSyncCacheGUID() const OVERRIDE;
+  virtual bool IsInitialized() const OVERRIDE;
+  virtual scoped_ptr<Subscription> RegisterOnInitializedCallback(
+    const base::Closure& callback) OVERRIDE;
+
+  void SetInitialized(bool is_initialized);
+
+ private:
+  bool is_initialized_;
+
+  scoped_ptr<DeviceInfo> local_device_info_;
+  base::CallbackList<void(void)> callback_list_;
+};
+
+}  // namespace browser_sync
+
+#endif  // CHROME_BROWSER_SYNC_GLUE_LOCAL_DEVICE_INFO_PROVIDER_MOCK_H_