Remove PATH tweaking for goma and clang from compile.py.

Remove PATH tweaking for goma and clang from compile.py.

PATH tweaking was too complicated for devs. Instead, gyp files should set
CC_wrapper and friends in their gyp files if use_goma=1 is set, then this
happens automatically. Since devs use this new workflow, all bots have been
converted to it too. This removes the old, now-unused way of PATH-tweaking from
compile.py. (Except for the codesearch bot, which still lives in the old world.)

It also removes the same tweaking from the make code. As far as I know, no bots
that use goma still use make, so this should be safe too.

BUG=332697
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281068

[iannucci, 2014-07-02 18:51:11]

awesome! lgtm.

[Nico, 2014-07-02 19:08:02]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-07-02 19:08:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/367133002/20001

[commit-bot: I haz the power, 2014-07-02 19:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 19:09:53]

Presubmit check for 367133002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Pylint (482 files) (59.14s) failed
************* Module
/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/compile.py
W0612:694,2:main_ninja: Unused variable 'orig_compiler'


Presubmit checks took 59.9s to calculate.

[Nico, 2014-07-02 19:20:45]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-07-02 19:21:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/367133002/40001

[Nico, 2014-07-02 19:21:26]

(cc'ing a few goma folks who are probably interested in this too)

[commit-bot: I haz the power, 2014-07-02 19:22:57]

Change committed as 281068

[Michael Achenbach, 2014-07-03 07:25:29]

https://codereview.chromium.org/367133002/diff/40001/build/scripts/slave/comp...
File build/scripts/slave/compile.py (left):

https://codereview.chromium.org/367133002/diff/40001/build/scripts/slave/comp...
build/scripts/slave/compile.py:612: clang_dir = os.path.join(options.src_dir,
Now that it landed, I see the problem. The v8 stand-alone clang builder was
relying on setting up the environment here. I'll come up with a quick fix on the
buildbot side before dealing with our gyp files.

[smut, 2014-07-09 19:05:34]

FYI this caused https://code.google.com/p/chromium/issues/detail?id=392579.