Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 367113006: Remove RenderView::GetPageId. (Closed)

Created:
6 years, 5 months ago by Avi (use Gerrit)
Modified:
6 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove RenderView::GetPageId. BUG=371151 TEST=everything still works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/public/renderer/render_view.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
John, this is for a bit later, when the last of the uses of this ...
6 years, 5 months ago (2014-07-03 19:48:08 UTC) #1
Avi (use Gerrit)
John is out this week.
6 years, 5 months ago (2014-07-07 18:36:35 UTC) #2
awong
LGTM Kill it with fire.
6 years, 5 months ago (2014-07-07 18:37:27 UTC) #3
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 5 months ago (2014-07-11 01:25:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/367113006/1
6 years, 5 months ago (2014-07-11 01:27:38 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 04:48:28 UTC) #6
Message was sent while issue was closed.
Change committed as 282545

Powered by Google App Engine
This is Rietveld 408576698