Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: Source/modules/webdatabase/SQLResultSet.h

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/speech/SpeechSynthesisVoice.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 20 matching lines...) Expand all
31 31
32 #include "bindings/core/v8/ScriptWrappable.h" 32 #include "bindings/core/v8/ScriptWrappable.h"
33 #include "modules/webdatabase/DatabaseBasicTypes.h" 33 #include "modules/webdatabase/DatabaseBasicTypes.h"
34 #include "modules/webdatabase/SQLResultSetRowList.h" 34 #include "modules/webdatabase/SQLResultSetRowList.h"
35 #include "wtf/ThreadSafeRefCounted.h" 35 #include "wtf/ThreadSafeRefCounted.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class ExceptionState; 39 class ExceptionState;
40 40
41 class SQLResultSet : public ThreadSafeRefCountedWillBeGarbageCollectedFinalized< SQLResultSet>, public ScriptWrappable { 41 class SQLResultSet FINAL : public ThreadSafeRefCountedWillBeGarbageCollected<SQL ResultSet>, public ScriptWrappable {
42 public: 42 public:
43 static PassRefPtrWillBeRawPtr<SQLResultSet> create() { return adoptRefWillBe Noop(new SQLResultSet); } 43 static PassRefPtrWillBeRawPtr<SQLResultSet> create() { return adoptRefWillBe Noop(new SQLResultSet); }
44 void trace(Visitor*); 44 void trace(Visitor*);
45 45
46 SQLResultSetRowList* rows() const; 46 SQLResultSetRowList* rows() const;
47 47
48 int64_t insertId(ExceptionState&) const; 48 int64_t insertId(ExceptionState&) const;
49 int rowsAffected() const; 49 int rowsAffected() const;
50 50
51 // For internal (non-JS) use 51 // For internal (non-JS) use
52 void setInsertId(int64_t); 52 void setInsertId(int64_t);
53 void setRowsAffected(int); 53 void setRowsAffected(int);
54 bool isValid() { return m_isValid; } 54 bool isValid() { return m_isValid; }
55 55
56 private: 56 private:
57 SQLResultSet(); 57 SQLResultSet();
58 58
59 RefPtrWillBeMember<SQLResultSetRowList> m_rows; 59 RefPtrWillBeMember<SQLResultSetRowList> m_rows;
60 int64_t m_insertId; 60 int64_t m_insertId;
61 int m_rowsAffected; 61 int m_rowsAffected;
62 bool m_insertIdSet; 62 bool m_insertIdSet;
63 bool m_isValid; 63 bool m_isValid;
64 }; 64 };
65 65
66 } // namespace blink 66 } // namespace blink
67 67
68 #endif // SQLResultSet_h 68 #endif // SQLResultSet_h
OLDNEW
« no previous file with comments | « Source/modules/speech/SpeechSynthesisVoice.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698