Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: Source/modules/geolocation/Coordinates.h

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/gamepad/WebKitGamepadList.cpp ('k') | Source/modules/geolocation/Geoposition.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 14 matching lines...) Expand all
25 25
26 #ifndef Coordinates_h 26 #ifndef Coordinates_h
27 #define Coordinates_h 27 #define Coordinates_h
28 28
29 #include "bindings/core/v8/ScriptWrappable.h" 29 #include "bindings/core/v8/ScriptWrappable.h"
30 #include "modules/EventModules.h" 30 #include "modules/EventModules.h"
31 #include "platform/heap/Handle.h" 31 #include "platform/heap/Handle.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class Coordinates : public GarbageCollectedFinalized<Coordinates>, public Script Wrappable { 35 class Coordinates : public GarbageCollected<Coordinates>, public ScriptWrappable {
36 public: 36 public:
37 static Coordinates* create(double latitude, double longitude, bool providesA ltitude, double altitude, double accuracy, bool providesAltitudeAccuracy, double altitudeAccuracy, bool providesHeading, double heading, bool providesSpeed, dou ble speed) 37 static Coordinates* create(double latitude, double longitude, bool providesA ltitude, double altitude, double accuracy, bool providesAltitudeAccuracy, double altitudeAccuracy, bool providesHeading, double heading, bool providesSpeed, dou ble speed)
38 { 38 {
39 return new Coordinates(latitude, longitude, providesAltitude, altitude, accuracy, providesAltitudeAccuracy, altitudeAccuracy, providesHeading, heading, providesSpeed, speed); 39 return new Coordinates(latitude, longitude, providesAltitude, altitude, accuracy, providesAltitudeAccuracy, altitudeAccuracy, providesHeading, heading, providesSpeed, speed);
40 } 40 }
41
41 void trace(Visitor*) { } 42 void trace(Visitor*) { }
42 43
43 double latitude() const { return m_latitude; } 44 double latitude() const { return m_latitude; }
44 double longitude() const { return m_longitude; } 45 double longitude() const { return m_longitude; }
45 double altitude(bool& isNull) const; 46 double altitude(bool& isNull) const;
46 double accuracy() const { return m_accuracy; } 47 double accuracy() const { return m_accuracy; }
47 double altitudeAccuracy(bool& isNull) const; 48 double altitudeAccuracy(bool& isNull) const;
48 double heading(bool& isNull) const; 49 double heading(bool& isNull) const;
49 double speed(bool& isNull) const; 50 double speed(bool& isNull) const;
50 51
(...skipping 24 matching lines...) Expand all
75 76
76 bool m_canProvideAltitude; 77 bool m_canProvideAltitude;
77 bool m_canProvideAltitudeAccuracy; 78 bool m_canProvideAltitudeAccuracy;
78 bool m_canProvideHeading; 79 bool m_canProvideHeading;
79 bool m_canProvideSpeed; 80 bool m_canProvideSpeed;
80 }; 81 };
81 82
82 } // namespace blink 83 } // namespace blink
83 84
84 #endif // Coordinates_h 85 #endif // Coordinates_h
OLDNEW
« no previous file with comments | « Source/modules/gamepad/WebKitGamepadList.cpp ('k') | Source/modules/geolocation/Geoposition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698