Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: Source/modules/push_messaging/PushManager.cpp

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add Finalizable transition type Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/push_messaging/PushManager.h" 6 #include "modules/push_messaging/PushManager.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "bindings/core/v8/ScriptPromiseResolver.h" 10 #include "bindings/core/v8/ScriptPromiseResolver.h"
11 #include "bindings/core/v8/ScriptState.h" 11 #include "bindings/core/v8/ScriptState.h"
12 #include "core/dom/Document.h" 12 #include "core/dom/Document.h"
13 #include "core/dom/ExecutionContext.h" 13 #include "core/dom/ExecutionContext.h"
14 #include "modules/push_messaging/PushController.h" 14 #include "modules/push_messaging/PushController.h"
15 #include "modules/push_messaging/PushError.h" 15 #include "modules/push_messaging/PushError.h"
16 #include "modules/push_messaging/PushRegistration.h" 16 #include "modules/push_messaging/PushRegistration.h"
17 #include "public/platform/WebPushClient.h" 17 #include "public/platform/WebPushClient.h"
18 #include "wtf/RefPtr.h" 18 #include "wtf/RefPtr.h"
19 19
20 namespace WebCore { 20 namespace WebCore {
21 21
22 PushManager::PushManager() 22 PushManager::PushManager()
23 { 23 {
24 ScriptWrappable::init(this); 24 ScriptWrappable::init(this);
25 } 25 }
26 26
27 PushManager::~PushManager() 27 DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(PushManager);
28 {
29 }
30 28
31 ScriptPromise PushManager::registerPushMessaging(ScriptState* scriptState, const String& senderId) 29 ScriptPromise PushManager::registerPushMessaging(ScriptState* scriptState, const String& senderId)
32 { 30 {
33 ASSERT(scriptState->executionContext()->isDocument()); 31 ASSERT(scriptState->executionContext()->isDocument());
34 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState); 32 RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scrip tState);
35 ScriptPromise promise = resolver->promise(); 33 ScriptPromise promise = resolver->promise();
36 blink::WebPushClient* client = PushController::clientFrom(toDocument(scriptS tate->executionContext())->page()); 34 blink::WebPushClient* client = PushController::clientFrom(toDocument(scriptS tate->executionContext())->page());
37 ASSERT(client); 35 ASSERT(client);
38 client->registerPushMessaging(senderId, new CallbackPromiseAdapter<PushRegis tration, PushError>(resolver)); 36 client->registerPushMessaging(senderId, new CallbackPromiseAdapter<PushRegis tration, PushError>(resolver));
39 return promise; 37 return promise;
40 } 38 }
41 39
42 } // namespace WebCore 40 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698