Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: Source/modules/indexeddb/IDBKeyRange.cpp

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add Finalizable transition type Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 IDBKeyRange::IDBKeyRange(IDBKey* lower, IDBKey* upper, LowerBoundType lowerType, UpperBoundType upperType) 54 IDBKeyRange::IDBKeyRange(IDBKey* lower, IDBKey* upper, LowerBoundType lowerType, UpperBoundType upperType)
55 : m_lower(lower) 55 : m_lower(lower)
56 , m_upper(upper) 56 , m_upper(upper)
57 , m_lowerType(lowerType) 57 , m_lowerType(lowerType)
58 , m_upperType(upperType) 58 , m_upperType(upperType)
59 { 59 {
60 ScriptWrappable::init(this); 60 ScriptWrappable::init(this);
61 } 61 }
62 62
63 DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(IDBKeyRange);
64
63 void IDBKeyRange::trace(Visitor* visitor) 65 void IDBKeyRange::trace(Visitor* visitor)
64 { 66 {
65 visitor->trace(m_lower); 67 visitor->trace(m_lower);
66 visitor->trace(m_upper); 68 visitor->trace(m_upper);
67 } 69 }
68 70
69 ScriptValue IDBKeyRange::lowerValue(ScriptState* scriptState) const 71 ScriptValue IDBKeyRange::lowerValue(ScriptState* scriptState) const
70 { 72 {
71 return idbKeyToScriptValue(scriptState, m_lower); 73 return idbKeyToScriptValue(scriptState, m_lower);
72 } 74 }
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 } 136 }
135 if (upper->isEqual(lower) && (lowerOpen || upperOpen)) { 137 if (upper->isEqual(lower) && (lowerOpen || upperOpen)) {
136 exceptionState.throwDOMException(DataError, "The lower key and upper key are equal and one of the bounds is open."); 138 exceptionState.throwDOMException(DataError, "The lower key and upper key are equal and one of the bounds is open.");
137 return 0; 139 return 0;
138 } 140 }
139 141
140 return IDBKeyRange::create(lower, upper, lowerOpen ? LowerBoundOpen : LowerB oundClosed, upperOpen ? UpperBoundOpen : UpperBoundClosed); 142 return IDBKeyRange::create(lower, upper, lowerOpen ? LowerBoundOpen : LowerB oundClosed, upperOpen ? UpperBoundOpen : UpperBoundClosed);
141 } 143 }
142 144
143 } // namespace WebCore 145 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698