src/heap-inl.h - Issue 367113003: Revert "Turn old space cons strings into regular external strings (not short)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-inl.h

Issue 367113003: Revert "Turn old space cons strings into regular external strings (not short)." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-inl.h

diff --git a/src/heap-inl.h b/src/heap-inl.h

index fdf86ff2cc85c18809afb6d91f0112d6835ce02f..844a3753493988b1dfbb9274cab3d72d0ca293dd 100644

--- a/src/heap-inl.h

+++ b/src/heap-inl.h

@@ -470,7 +470,8 @@ bool Heap::AllowedToBeMigrated(HeapObject* obj, AllocationSpace dst) {

return dst == src || dst == TargetSpaceId(type);

case OLD_POINTER_SPACE:

return dst == src && (dst == TargetSpaceId(type) || obj->IsFiller() ||

- (obj->IsExternalString()));

+ (obj->IsExternalString() &&

+ ExternalString::cast(obj)->is_short()));

case OLD_DATA_SPACE:

return dst == src && dst == TargetSpaceId(type);

case CODE_SPACE:

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »