Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 367103003: Don't turn all <code> tags into block elements. (Closed)

Created:
6 years, 5 months ago by Yaron
Modified:
6 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews, sunangel
Project:
chromium
Visibility:
Public.

Description

Don't turn all <code> tags into block elements. Many pages use these inline as part of text and this breaks formatting. Samples: http://neugierig.org/software/blog/2014/07/anti-dashboard-manifesto.html http://git-scm.com/book/en/Git-Internals-Git-Objects More tweaking to come but this is clearly suboptimal. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M components/dom_distiller/core/css/distilledpage.css View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
6 years, 5 months ago (2014-07-02 17:53:15 UTC) #1
nyquist
lgtm
6 years, 5 months ago (2014-07-02 18:09:39 UTC) #2
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 5 months ago (2014-07-02 18:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/367103003/1
6 years, 5 months ago (2014-07-02 18:11:04 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 21:52:58 UTC) #5
Message was sent while issue was closed. 
Change committed as 281096

Powered by Google App Engine
This is Rietveld 408576698