Push API: set mock behavior from layout tests and exercise success.

Push API: set mock behavior from layout tests and exercise the success path.

BUG=350377
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177482

[Michael van Ouwerkerk, 2014-07-02 16:27:45]

Peter, can you please take a look?

[Peter Beverloo, 2014-07-02 16:40:48]

lgtm % comments

https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging.html (right):

https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:19:
shouldBe('navigator.push.register("senderId").constructor', 'Promise');
Exposure of the API (and the properties/functions of it) should be in a separate
test from testing whether registration succeeds or fails with the expected
values.

https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:22:
window.testRunner.setMockPushClientError('message');
Four space indent, please.

[Michael van Ouwerkerk, 2014-07-03 14:16:41]

Thanks Peter!

https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging.html (right):

https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:19:
shouldBe('navigator.push.register("senderId").constructor', 'Promise');
On 2014/07/02 16:40:47, Peter Beverloo wrote:
> Exposure of the API (and the properties/functions of it) should be in a
separate
> test from testing whether registration succeeds or fails with the expected
> values.

Done.

https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:22:
window.testRunner.setMockPushClientError('message');
On 2014/07/02 16:40:47, Peter Beverloo wrote:
> Four space indent, please.

Done.

[Michael van Ouwerkerk, 2014-07-03 14:16:44]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2014-07-03 14:17:17]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/367063002/2...

[commit-bot: I haz the power, 2014-07-03 15:21:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15301)

[commit-bot: I haz the power, 2014-07-03 15:51:03]

Change committed as 177482