Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 367063002: Push API: set mock behavior from layout tests and exercise success. (Closed)

Created:
6 years, 5 months ago by Michael van Ouwerkerk
Modified:
6 years, 5 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Push API: set mock behavior from layout tests and exercise the success path. BUG=350377 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177482

Patch Set 1 #

Total comments: 4

Patch Set 2 : Split tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -18 lines) Patch
M LayoutTests/push_messaging/push-messaging.html View 1 1 chunk +24 lines, -13 lines 0 comments Download
A LayoutTests/push_messaging/push-messaging-api-surface.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/push_messaging/push-messaging-api-surface-expected.txt View 1 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/push_messaging/push-messaging-expected.txt View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael van Ouwerkerk
Peter, can you please take a look?
6 years, 5 months ago (2014-07-02 16:27:45 UTC) #1
Peter Beverloo
lgtm % comments https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/push-messaging.html File LayoutTests/push_messaging/push-messaging.html (right): https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/push-messaging.html#newcode19 LayoutTests/push_messaging/push-messaging.html:19: shouldBe('navigator.push.register("senderId").constructor', 'Promise'); Exposure of the API ...
6 years, 5 months ago (2014-07-02 16:40:48 UTC) #2
Michael van Ouwerkerk
Thanks Peter! https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/push-messaging.html File LayoutTests/push_messaging/push-messaging.html (right): https://codereview.chromium.org/367063002/diff/1/LayoutTests/push_messaging/push-messaging.html#newcode19 LayoutTests/push_messaging/push-messaging.html:19: shouldBe('navigator.push.register("senderId").constructor', 'Promise'); On 2014/07/02 16:40:47, Peter Beverloo ...
6 years, 5 months ago (2014-07-03 14:16:41 UTC) #3
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 5 months ago (2014-07-03 14:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/367063002/20001
6 years, 5 months ago (2014-07-03 14:17:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 15:21:11 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 15:51:03 UTC) #7
Message was sent while issue was closed.
Change committed as 177482

Powered by Google App Engine
This is Rietveld 408576698