Issue 367033002: Reland "Linux perf tool support update + refactoring." (r22146, attempt #5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367033002: Reland "Linux perf tool support update + refactoring." (r22146, attempt #5) (Closed)

Created:
6 years, 5 months ago by Jarin

Modified:
6 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Reland "Linux perf tool support update + refactoring." (r22146, fifth attempt) Bringing the offending timer functions to the platform dependent files. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22210

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+466 lines, -173 lines)			Patch
M	BUILD.gn	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/base/platform/platform.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/base/platform/platform-posix.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	src/base/platform/platform-win32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/base/platform/time.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/base/platform/time.cc	View	1 2 3 4 5 6	3 chunks	+85 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	1 2 3 4	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/log.cc	View	1 2 3 4 5 6	2 chunks	+1 line, -166 lines	0 comments	Download
A	src/perf-jit.h	View	1 2 3 4 5 6	1 chunk	+120 lines, -0 lines	0 comments	Download
A	src/perf-jit.cc	View	1 2 3 4 5 6	1 chunk	+147 lines, -0 lines	0 comments	Download
A	src/third_party/kernel/tools/perf/util/jitdump.h	View	1 2 3 4 5 6	1 chunk	+83 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2014/07/02 15:41:36, jarin wrote: > Could you have another look at this, please? lgtm.

6 years, 5 months ago (2014-07-03 08:04:12 UTC) #2

Jarin

6 years, 5 months ago (2014-07-03 19:19:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r22210 (presubmit successful).