Componentize TemplateURLService

Componentize TemplateURLService

Move TemplateURLService, SearchHostToURLsMap, util.cc from chrome/browser/search_engines to components/search_engines
Move KeywordTable and KeywordWeDataService from chrome/browser/webdata to components/search_engines
Fix DEPS, OWNERS and gyp.
Replace HistoryDatabase in keyword_table.cc with URLDatabase.

BUG=386367
TEST=build and checkdeps
R=blundell@chromium.org, jochen@chromium.org, pkasting@chromium.org
TBR=atwilson@chromium.org as an owner of sync, erikwright@chromium.org as an owner of sql

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281350

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281403

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281455

[hashimoto, 2014-07-02 13:10:19]

This change depends on "No chrome dependencies in
TemplateURLService"(https://codereview.chromium.org/367863005/).

[Peter Kasting, 2014-07-02 18:45:40]

LGTM

[hashimoto, 2014-07-03 07:39:15]

Colin, could you review DEPS changes as an owner of components?
This change should be commited after https://codereview.chromium.org/367863005/.

[blundell, 2014-07-03 08:03:13]

//components LGTM

[hashimoto, 2014-07-03 13:17:50]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2014-07-03 13:17:58]

The CQ bit was unchecked by hashimoto@chromium.org

[hashimoto, 2014-07-03 13:23:09]

TBRing jochen@chromium.org for include fix.

TBRing owners of directories added to DEPS:
 - erikwright@chromium.org as an owner of sql 
 - atwilson@chromium.org as an owner of sync

[hashimoto, 2014-07-03 13:23:16]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-07-03 13:24:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/367023002/100001

[blundell, 2014-07-03 13:24:46]

BTW: w00t!!!

[commit-bot: I haz the power, 2014-07-03 15:21:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-03 15:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-03 15:26:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[jochen (gone - plz use gerrit), 2014-07-03 19:39:15]

changing the includes lgtm

not really related to this CL, but components should be in their own namespace.

[hashimoto, 2014-07-04 01:19:12]

On 2014/07/03 19:39:15, jochen wrote:
> changing the includes lgtm
> 
> not really related to this CL, but components should be in their own
namespace.

Yes, they should be in namespaces.
But I think it's OK to move code to components/ without changing the namespace
first
because there are many components who don't have their own namespaces.
Also, doing all of <cutting dependencies between classes> + <moving code between
directories> + <changing the namespace> 
at the same time requires a lot of hassle.
I think it's not too late to put classes in the proper namespace after the code
is moved to components/.

BTW, "search_engines::" looks a bit too long as a prefix for names of classes
with this popularity.
Maybe we should coin a shorter but still distinguishable name for this component
before putting classes in a namespace?

[hashimoto, 2014-07-04 01:21:19]

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  components/search_engines/template_url_service.cc, line 484, 148 chars

This presubmit warning is made against the existing long comment line which
contains a URL.
Going to bypass this check.

[hashimoto, 2014-07-04 01:22:32]

Committed patchset #5 manually as r281350 (presubmit successful).

[hashimoto, 2014-07-04 04:58:10]

A revert of this CL has been created in
https://codereview.chromium.org/363323007/ by hashimoto@chromium.org.

The reason for reverting is: Failed on android_aosp:
http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%....

[jochen (gone - plz use gerrit), 2014-07-04 05:33:11]

i dunno, so you're signing up for touching all the files again?

I don't think search_engines is a particularly long name...

[hashimoto, 2014-07-04 05:57:05]

On 2014/07/04 05:33:11, jochen wrote:
> i dunno, so you're signing up for touching all the files again?
I only manually edited DEPS, OWNERS and gyp.
Most of this change is done by tools/git/move_source_file.py.
So introducing the namespace after moving the files doesn't require me an
additional effort.
Filed crbug.com/391373 for this.
> 
> I don't think search_engines is a particularly long name...
Then namespace search_engines should be fine.

[hashimoto, 2014-07-04 06:43:41]

Hi Colin,

This change was once committed but got reverted because Android AOSP bots
generated GYP errors.

Could you take another look at components/components.gyp?

It seems the GYP error generated by Android AOSP is caused by the sync.gyp:sync
dependency added to search_engines. (even if it doesn't need this target!)
The new patch set fixes the AOSP build by moving search_engines to under
'android_webview_build == 0'.

[blundell, 2014-07-04 07:42:08]

lgtm

[hashimoto, 2014-07-04 13:45:37]

Committed patchset #6 manually as r281403 (presubmit successful).

[timvolodine, 2014-07-04 14:50:47]

A revert of this CL has been created in
https://codereview.chromium.org/368273011/ by timvolodine@chromium.org.

The reason for reverting is: this patch breaks compile on clankium-tot-builder
bot
(https://uberchromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-...)
.

[timvolodine, 2014-07-04 14:51:16]

A revert of this CL has been created in
https://codereview.chromium.org/369303002/ by timvolodine@chromium.org.

The reason for reverting is: this patch breaks compile on clankium-tot-builder
bot
(https://uberchromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-...)
.

[hashimoto, 2014-07-05 00:30:11]

Committed patchset #7 manually as r281455 (presubmit successful).

[hashimoto, 2014-07-05 00:33:15]

On 2014/07/04 14:51:16, timvolodine wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/369303002/ by mailto:timvolodine@chromium.org.
> 
> The reason for reverting is: this patch breaks compile on clankium-tot-builder
> bot
>
(https://uberchromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-...)
> .

Please do not revert an upstream change to fix your Chromium derivative.
You should replace '#include
"chrome/browser/search_engines/template_url_service.h"' with '#include
"components/search_engines/template_url_service.h"' in
contextual_search_delegate.cc and contextual_search_delegate_unittest.cc in your
repository.