Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 367003002: Make more [TreatNullAs=NullString] DOMString arguments nullable (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, tzik, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, nessy, loislo+blink_chromium.org, sof, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, lushnikov+blink_chromium.org, vcarbune.chromium, philipj_slow, eustas+blink_chromium.org, gasubic, watchdog-blink-watchlist_google.com, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, sergeyv+blink_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make more [TreatNullAs=NullString] DOMString arguments nullable Fix handling of DOMString? combined with [TreatUndefinedAs=NullString] to behave the same as [TreatNullAs=NulllString] combined with it, and then change method arguments with TreatNullAs+TreatUndefinedAs to nullable with just TreatUndefinedAs. This does not alter behavior or change generated code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177396

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 2 comments Download
M Source/core/fileapi/Blob.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntry.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntrySync.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/Entry.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/EntrySync.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
PTAL https://codereview.chromium.org/367003002/diff/1/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/367003002/diff/1/Source/core/dom/Document.idl#newcode101 Source/core/dom/Document.idl:101: [TreatUndefinedAs=NullString, Default=Undefined] optional DOMString? value); If we fix ...
6 years, 5 months ago (2014-07-02 12:42:20 UTC) #1
haraken
LGTM https://codereview.chromium.org/367003002/diff/1/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/367003002/diff/1/Source/core/dom/Document.idl#newcode101 Source/core/dom/Document.idl:101: [TreatUndefinedAs=NullString, Default=Undefined] optional DOMString? value); On 2014/07/02 12:42:20, ...
6 years, 5 months ago (2014-07-02 12:50:27 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-02 14:22:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/367003002/1
6 years, 5 months ago (2014-07-02 14:23:41 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 15:34:34 UTC) #5
Message was sent while issue was closed.
Change committed as 177396

Powered by Google App Engine
This is Rietveld 408576698