Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 366963002: Revert of Enable extended debugging symbols to including macro expansion. (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Enable extended debugging symbols to including macro expansion. (https://codereview.chromium.org/198363002/) Reason for revert: Linux dbg builder runs out of memory Original issue's description: > Adding -g3 to get macro expansion support. (Default is -g2.) > Adding -gdwarf-4 for macro expansion support. > > * gcc 4.6 outputs DWARF-2 by default > * gcc 4.7 outputs DWARF-4 by default > * clang <3.4 outputs DWARF-3 by default > * clang >3.4 outputs DWARF-4 by default > > From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html > > -g3 > > Level 3 includes extra information, such as all the macro > > definitions present in the program. Some debuggers support macro > > expansion when you use -g3. > > > > -gdwarf-4 > > Produce debugging information in DWARF format (if that is > > supported). The value of version may be either 2, 3 or 4; the > > default version for most targets is 4. Note that with DWARF > > Version 2, some ports require and always use some non-conflicting > > DWARF 3 extensions in the unwind tables. > > > > Version 4 may require GDB 7.0 and -fvar-tracking-assignments for > > maximum benefit. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257944 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280980 TBR=mark@chromium.org,mithro@mithis.com,thestig@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/common.gypi View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Enable extended debugging symbols to including macro expansion.
6 years, 5 months ago (2014-07-02 09:16:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/366963002/1
6 years, 5 months ago (2014-07-02 09:18:06 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 09:18:07 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-02 09:18:07 UTC) #4
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-02 09:28:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/366963002/1
6 years, 5 months ago (2014-07-02 09:30:25 UTC) #6
commit-bot: I haz the power
Change committed as 280986
6 years, 5 months ago (2014-07-02 09:31:40 UTC) #7
Mark Mentovai
LGTM. Is this speculative or do you know that this will fix the builder?
6 years, 5 months ago (2014-07-02 12:24:16 UTC) #8
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-02 12:41:55 UTC) #9
Message was sent while issue was closed.
On 2014/07/02 at 12:24:16, mark wrote:
> LGTM. Is this speculative or do you know that this will fix the builder?

it fixed the builder

Powered by Google App Engine
This is Rietveld 408576698