Add //components/webdata/common to the GN build.

Add //components/webdata/common to the GN build.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282671

[jbroman, 2014-07-04 18:44:30]

This seems straightforward enough. Please look closely, though, as I don't know
GN well.

[tfarina, 2014-07-04 23:43:29]

https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
File components/webdata/common/BUILD.gn (right):

https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
components/webdata/common/BUILD.gn:29: "..",
are you sure you need this? I see webdata.gypi has this, but I think GN has this
builtin, so you don't really need this here.

https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
components/webdata/common/BUILD.gn:37: "//base",
the above source list does not need chrome/browser/webdata,
components/autofill/core/browser, components/signin/core/browser?

I checked running the following command line:

$ g grep -h "include \"" components/webdata/common/ | sort | uniq

What gn check says?

[jbroman, 2014-07-07 14:07:59]

On 2014/07/04 23:43:29, tfarina wrote:
>
https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
> File components/webdata/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
> components/webdata/common/BUILD.gn:29: "..",
> are you sure you need this? I see webdata.gypi has this, but I think GN has
this
> builtin, so you don't really need this here.
> 
>
https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
> components/webdata/common/BUILD.gn:37: "//base",
> the above source list does not need chrome/browser/webdata,
> components/autofill/core/browser, components/signin/core/browser?
> 
> I checked running the following command line:
> 
> $ g grep -h "include \"" components/webdata/common/ | sort | uniq
> 
> What gn check says?

Those are only used in test files which are not in this target; I checked using
`gn check` and verified with

$ git grep "#include \"" components/webdata/common | sed
's/\(.*\):\(.*\)/\2\t\1/' | sort

Presumably whichever target includes these test files should have an appropriate
dependency when it is migrated from gyp to gn.

[jbroman, 2014-07-07 14:09:28]

https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
File components/webdata/common/BUILD.gn (right):

https://codereview.chromium.org/366933003/diff/20001/components/webdata/commo...
components/webdata/common/BUILD.gn:29: "..",
On 2014/07/04 23:43:28, tfarina wrote:
> are you sure you need this? I see webdata.gypi has this, but I think GN has
this
> builtin, so you don't really need this here.

Quite correct. This path isn't even right anymore, since the BUILD.gn file is
not in the same place as the .gyp file. Removed.

[brettw, 2014-07-08 21:16:44]

lgtm

[jbroman, 2014-07-09 13:15:26]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-07-09 13:16:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbroman@chromium.org/366933003/40001

[commit-bot: I haz the power, 2014-07-09 14:20:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-09 14:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:22:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[jbroman, 2014-07-11 19:43:49]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-07-11 19:47:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbroman@chromium.org/366933003/60001

[commit-bot: I haz the power, 2014-07-11 19:50:02]

Change committed as 282671