Issue 366913007: Oilpan: fix build after r177376.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366913007: Oilpan: fix build after r177376. (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
haraken, oilpan-reviews

CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r177376. Move implementation of create() into .cpp to bring the MediaQueryEvaluator type completely into scope. TBR=haraken@chromium.org,oilpan-reviews@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177388

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	Source/core/css/MediaQueryMatcher.h	View		1 chunk	+2 lines, -2 lines	1 comment	Download
	M	Source/core/css/MediaQueryMatcher.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/366913007/diff/1/Source/core/css/MediaQueryMatcher.h File Source/core/css/MediaQueryMatcher.h (right): https://codereview.chromium.org/366913007/diff/1/Source/core/css/MediaQueryMatcher.h#newcode42 Source/core/css/MediaQueryMatcher.h:42: DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(MediaQueryMatcher) We normally add ";" though.

6 years, 5 months ago (2014-07-02 14:06:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/366913007/1

6 years, 5 months ago (2014-07-02 14:06:27 UTC) #4

Message was sent while issue was closed.

Change committed as 177388

Expand Messages | Collapse Messages