Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 366913005: [DevTools] Don't select anything when no items in FilteredItemSelectionDialog. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
vsevik, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Don't select anything when no items in FilteredItemSelectionDialog. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-02 10:27:49 UTC) #1
lushnikov
lgtm
6 years, 5 months ago (2014-07-02 12:36:21 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 5 months ago (2014-07-02 12:36:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/366913005/1
6 years, 5 months ago (2014-07-02 12:37:02 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:43:11 UTC) #5
Message was sent while issue was closed.
Change committed as 177387

Powered by Google App Engine
This is Rietveld 408576698