Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 366913004: Moved modules files from bindings/core/v8/custom to bindings/modules/v8/custom. (Closed)

Created:
6 years, 5 months ago by tasak
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Moved modules files from bindings/core/v8/custom to bindings/modules/v8/custom. - V8CustomSQLStatementErrorCallback, V8EntryCustom and V8EntrySyncCustom should be placed under modules/v8/custom. - Removed unused include (for modules). BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -185 lines) Patch
D Source/bindings/core/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
D Source/bindings/core/v8/custom/V8EntryCustom.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/bindings/core/v8/custom/V8EntrySyncCustom.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
A + Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/modules/v8/custom/V8EntryCustom.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/modules/v8/custom/V8EntrySyncCustom.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/bindings/modules/v8/custom/custom.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tasak
Would you review this CL? I found some mistakes in Blink r177062.
6 years, 5 months ago (2014-07-02 07:40:09 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-02 07:53:26 UTC) #2
tasak
The CQ bit was checked by tasak@google.com
6 years, 5 months ago (2014-07-02 07:54:50 UTC) #3
tasak
On 2014/07/02 07:53:26, haraken wrote: > LGTM Thank you.
6 years, 5 months ago (2014-07-02 07:54:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/366913004/1
6 years, 5 months ago (2014-07-02 07:55:30 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:04:46 UTC) #6
Message was sent while issue was closed.
Change committed as 177373

Powered by Google App Engine
This is Rietveld 408576698