Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 3669005: Roll gtest to r445. (Closed)

Created:
10 years, 2 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Roll gtest to r445. I want to get to r492 to pick up the fix for http://code.google.com/p/googletest/issues/detail?id=321 (fix clang warning when building tests in release), but rolling all the way doesn't pass the try servers – gtest introduced some new warnings somewhere in between. gtest changelog: r445 Fixes warnings when built by GCC with -Wswitch-default. r444 Fixes definitions from pthread.h used before the header inclusion. r443 Makes gtest_break_on_failure_unittest work on minGW; improves the NULL-dereferencing hack to work with LLVM. r442 Fixes sample code in the "Important note for Visual C++ users" section of the GoogleTestPrimer wiki page. r441 akes gtest report failures in ad hoc test assertions executed before RUN_ALL_TESTS(). r440 Adds tests for SkipPrefix(). r439 Fixes a wrong comment for OnTestPartResult(). r438 Fixes a typo in the event listener sample. r437 Fixes issue 286. r436 Corrects test binary paths in the CMake build script. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62148

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
10 years, 2 months ago (2010-10-11 16:02:33 UTC) #1
LGTM with green trybots.

Powered by Google App Engine
This is Rietveld 408576698