Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 366873007: Mojo: Reformat parser_unittest.py. (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Reformat parser_unittest.py. I guess this these are parser tests, and whitespace will be eaten by the lexer. So I may as well make the tests kind of readable. Also: * Fix line number reporting (and snippet generation) for fixed size array error reporting (we only get line numbers for things from the lexer). * Rename foos in parser.py to foo_list, for increased visibility. * A few more small style fixes. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281069

Patch Set 1 #

Total comments: 2

Patch Set 2 : docstring for BaseNode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -392 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 1 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 6 chunks +24 lines, -23 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 5 chunks +385 lines, -369 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-02 17:23:36 UTC) #1
jamesr
lgtm https://codereview.chromium.org/366873007/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py File mojo/public/tools/bindings/pylib/mojom/parse/ast.py (right): https://codereview.chromium.org/366873007/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py#newcode20 mojo/public/tools/bindings/pylib/mojom/parse/ast.py:20: is this what the pep8 formatter would do?
6 years, 5 months ago (2014-07-02 17:36:29 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/366873007/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py File mojo/public/tools/bindings/pylib/mojom/parse/ast.py (right): https://codereview.chromium.org/366873007/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/ast.py#newcode20 mojo/public/tools/bindings/pylib/mojom/parse/ast.py:20: On 2014/07/02 17:36:29, jamesr wrote: > is this ...
6 years, 5 months ago (2014-07-02 17:59:04 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 5 months ago (2014-07-02 18:10:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/366873007/20001
6 years, 5 months ago (2014-07-02 18:11:53 UTC) #5
viettrungluu
6 years, 5 months ago (2014-07-02 19:24:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r281069 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698