Land Recent QUIC Changes.

net/quic/quic_connection.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The entity that handles framing writes for a Quic client or server.
 // Each QuicSession will have a connection associated with it.
 //
 // On the server side, the Dispatcher handles the raw reads, and hands off
 // packets via ProcessUdpPacket for framing and processing.
 //
@@ skipping 288 matching lines @@
 
   // Called when a packet has been finally sent to the network.
   bool OnPacketSent(WriteResult result);
 
   // If the socket is not blocked, writes queued packets.
   void WriteIfNotBlocked();
 
   // Do any work which logically would be done in OnPacket but can not be
   // safely done until the packet is validated.  Returns true if the packet
   // can be handled, false otherwise.
-  bool ProcessValidatedPacket();
+  virtual bool ProcessValidatedPacket();

[wtc, 2014/07/02 22:56:48]

Why does this method need to be virtual? I don't see any subclass override this
method.

[ramant (doing other things), 2014/07/16 19:43:35]

Our internal code override's this method. It is not overwritten in chrome.
Diverged chrome version of this file from internal source tree by removing the
virtual.

Done.

 
   // The version of the protocol this connection is using.
   QuicVersion version() const { return framer_.version(); }
 
   // The versions of the protocol that this connection supports.
   const QuicVersionVector& supported_versions() const {
     return framer_.supported_versions();
   }
 
   // From QuicFramerVisitorInterface
@@ skipping 185 matching lines @@
 
   QuicConnectionHelperInterface* helper() { return helper_; }
 
   // Selects and updates the version of the protocol being used by selecting a
   // version from |available_versions| which is also supported. Returns true if
   // such a version exists, false otherwise.
   bool SelectMutualVersion(const QuicVersionVector& available_versions);
 
   QuicPacketWriter* writer() { return writer_; }
 
+  bool peer_port_changed() const { return peer_port_changed_; }
+
+  const QuicReceivedPacketManager& received_packet_manager() {

[wtc, 2014/07/02 22:56:48]

Mark this method const?

[ramant (doing other things), 2014/07/16 19:43:35]

Done.

+    return received_packet_manager_;
+  }
+
+  QuicPacketSequenceNumber sequence_number_of_last_sent_packet() const {
+    return sequence_number_of_last_sent_packet_;
+  }
+
  private:
   friend class test::QuicConnectionPeer;
 
   // Packets which have not been written to the wire.
   // Owns the QuicPacket* packet.
   struct QueuedPacket {
     QueuedPacket(SerializedPacket packet,
                  EncryptionLevel level,
                  TransmissionType transmission_type);
 
@@ skipping 238 matching lines @@
   // If non-empty this contains the set of versions received in a
   // version negotiation packet.
   QuicVersionVector server_supported_versions_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicConnection);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CONNECTION_H_