Source/modules/screen_orientation/ScreenOrientation.idl - Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.idl

Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/screen_orientation/ScreenOrientation.cpp ('K') | « Source/modules/screen_orientation/ScreenOrientation.cpp ('k') | Source/modules/screen_orientation/ScreenOrientationController.h » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientation.idl

diff --git a/Source/modules/screen_orientation/ScreenOrientation.idl b/Source/modules/screen_orientation/ScreenOrientation.idl

index f869dc547f380072cd5ab3d132e823b58d0367ab..67f65ecc0bd0d5fa64456ec36ae7461346cbe9e7 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.idl

+++ b/Source/modules/screen_orientation/ScreenOrientation.idl

@@ -2,13 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-enum OrientationType {

- "portrait-primary",

- "portrait-secondary",

- "landscape-primary",

- "landscape-secondary"

-};

enum OrientationLockType {

"any",

"natural",

@@ -23,7 +16,7 @@ enum OrientationLockType {

[

RuntimeEnabled=ScreenOrientation

] partial interface Screen {

- readonly attribute OrientationType orientation;

+ readonly attribute OrientationInformation orientation;

[CallWith=ScriptState] Promise lockOrientation(OrientationLockType orientation);