LayoutTests/screen_orientation/orientationchange-event.html - Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/orientationchange-event.html

Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update ctor listing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/orientation-attribute-expected.txt ('k') | LayoutTests/screen_orientation/orientationchange-event-subframe.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/orientationchange-event.html

diff --git a/LayoutTests/screen_orientation/orientationchange-event.html b/LayoutTests/screen_orientation/orientationchange-event.html

index 54d387f6bafd57bba3d049a38888268b11bfade6..1c797ac6fe5f6bbbe92c0bf79a02546bc433d473 100644

--- a/LayoutTests/screen_orientation/orientationchange-event.html

+++ b/LayoutTests/screen_orientation/orientationchange-event.html

@@ -12,7 +12,7 @@ var orientations = [

'landscape-secondary'

];

-var currentIndex = orientations.indexOf(window.screen.orientation);

+var currentIndex = orientations.indexOf(window.screen.orientation.type);

// Count the number of calls received from the EventHandler set on window.onorientationchange.

var orientationChangeEventHandlerCalls = 0;

// Count the number of calls received from the listener set with window.addEventListene().

@@ -42,7 +42,7 @@ for (var i = 0; i < 4; ++i) {

window.testRunner.setMockScreenOrientation(orientations[getNextIndex()]);

currentIndex = getNextIndex();

- assert_equals(screen.orientation, orientations[currentIndex]);

+ assert_equals(screen.orientation.type, orientations[currentIndex]);

todo_equals(orientationChangeEventHandlerCalls, i + 1);

assert_equals(orientationChangeEventListenerCalls, i + 1);

@@ -51,7 +51,7 @@ for (var i = 0; i < 4; ++i) {

test(function() {

window.testRunner.setMockScreenOrientation(orientations[currentIndex]);

- assert_equals(screen.orientation, orientations[currentIndex]);

+ assert_equals(screen.orientation.type, orientations[currentIndex]);

todo_equals(orientationChangeEventHandlerCalls, 4);

assert_equals(orientationChangeEventListenerCalls, 4);