LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html - Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update ctor listing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

diff --git a/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html b/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

index 0c56955351bd8573e893ea6d48268be7ff778c7e..58f27589aeaec8b35088ddb889b09c0762cd8580 100644

--- a/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

+++ b/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

@@ -11,7 +11,7 @@ function onOrientationChangeEvent(ev) {

}

function completeTest() {

- shouldBeEqualToString("screen.orientation", "portrait-primary");

+ shouldBeEqualToString("screen.orientation.type", "portrait-primary");

screen.unlockOrientation();

finishJSTest();

}

@@ -22,7 +22,7 @@ function typeErrorEnum(argStr) {

return "TypeError: Failed to execute 'lockOrientation' on 'Screen': parameter 1 ('" + argStr + "') is not a valid enum value.";

}

-shouldBeEqualToString("screen.orientation", "portrait-primary");

+shouldBeEqualToString("screen.orientation.type", "portrait-primary");

// Bad argument to lockOrientation(), we should not get locked.

shouldThrow("screen.lockOrientation(['portrait-primary', 'invalid-orientation'])", "typeErrorEnum('portrait-primary,invalid-orientation')");

shouldThrow("screen.lockOrientation(['portrait-primary', null])", "typeErrorEnum('portrait-primary,')");