[screen-orientation] Expose orientation info in OrientationInformation interface.

Source/modules/screen_orientation/OrientationInformation.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef OrientationInformation_h
+#define OrientationInformation_h
+
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "public/platform/WebScreenOrientationType.h"
+
+namespace WebCore {
+
+class OrientationInformation FINAL
+    : public GarbageCollectedFinalized<OrientationInformation>
+    , public ScriptWrappable {
+public:
+    // Returns an OrientationInformation instance filed with fake values.
+    static OrientationInformation* createFake();

[abarth-chromium, 2014/07/02 18:25:09]

I wonder if we should pick a slightly different name for this function. 
|createFake| makes me think that this is a something for testing.  Maybe
|createPlaceholder| ?

[mlamouri (slow - plz ping), 2014/07/02 19:18:12]

Removed createFake() entirely.

+
+    virtual ~OrientationInformation();

[abarth-chromium, 2014/07/02 18:25:09]

Why does this destructor need to be virtual?

[mlamouri (slow - plz ping), 2014/07/02 19:18:11]

Removed destructor.

+
+    bool initialized() const;
+
+    String type() const;
+    unsigned short angle() const;
+
+    void trace(Visitor*) { }
+
+protected:
+    friend class ScreenOrientationController;

[abarth-chromium, 2014/07/02 18:25:10]

Please don't use friends.  Just expose the functions you need to expose.

[mlamouri (slow - plz ping), 2014/07/02 19:18:12]

Done.

+
+    OrientationInformation();
+    OrientationInformation(const OrientationInformation&);

[abarth-chromium, 2014/07/02 18:25:09]

It's unusual to have a copy constructor for a DOM object.  Maybe use a static
|clone| function instead?

[mlamouri (slow - plz ping), 2014/07/02 19:18:11]

Done.

+    bool operator==(const OrientationInformation&);
+    bool operator!=(const OrientationInformation&);

[abarth-chromium, 2014/07/02 18:25:09]

These are also unusual.  Maybe an |equals| function?

[mlamouri (slow - plz ping), 2014/07/02 19:18:12]

Done.

+
+    void setType(blink::WebScreenOrientationType);
+    void setAngle(unsigned short);

[abarth-chromium, 2014/07/02 18:25:09]

You can just make these public.

[mlamouri (slow - plz ping), 2014/07/02 19:18:11]

Done.

+
+private:
+    blink::WebScreenOrientationType m_type;
+    unsigned short m_angle;
+};
+
+} // namespace WebCore
+
+#endif // OrientationInformation_h