Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart

Issue 366853007: dart2dart: Support for inner functions in new IR. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: SVN rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart b/sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart
index 5f48fd7265b79dc450460f4d882ee2cd19888492..f167ba7d9a18ae43d69977fa7f882d51479287f0 100644
--- a/sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart
+++ b/sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart
@@ -194,6 +194,21 @@ class IRTracer extends TracerUtil implements ir.Visitor {
printStmt(dummy, "Branch $condition ($trueCont, $falseCont)");
}
+ visitSetClosureVariable(ir.SetClosureVariable node) {
+ String dummy = names.name(node);
+ String variable = node.variable.name;
+ String value = formatReference(node.value);
+ printStmt(dummy, 'SetClosureVariable $variable = $value');
+ visit(node.body);
+ }
+
+ visitDeclareFunction(ir.DeclareFunction node) {
+ String dummy = names.name(node);
+ String variable = node.variable.name;
+ printStmt(dummy, 'DeclareFunction $variable');
+ visit(node.body);
+ }
+
String formatReference(ir.Reference ref) {
ir.Definition target = ref.definition;
if (target is ir.Continuation && target.body == null) {
@@ -226,9 +241,19 @@ class IRTracer extends TracerUtil implements ir.Visitor {
}
visitReifyTypeVar(ir.ReifyTypeVar node) {
- return "ReifyTypeVar ${node.element.name}";
+ return "ReifyTypeVar ${node.typeVariable.name}";
+ }
+
+ visitCreateFunction(ir.CreateFunction node) {
+ return "CreateFunction ${node.definition.element.name}";
+ }
+
+ visitGetClosureVariable(ir.GetClosureVariable node) {
+ String variable = node.variable.name;
+ return 'GetClosureVariable $variable';
}
+
visitCondition(ir.Condition c) {}
visitExpression(ir.Expression e) {}
visitPrimitive(ir.Primitive p) {}
@@ -318,39 +343,39 @@ class BlockCollector extends ir.Visitor {
visit(exp.body);
}
- visitInvokeStatic(ir.InvokeStatic exp) {
- ir.Definition target = exp.continuation.definition;
+ void addEdgeToContinuation(ir.Reference continuation) {
+ ir.Definition target = continuation.definition;
if (target is ir.Continuation && target.body != null) {
current_block.addEdgeTo(getBlock(target));
}
}
+ visitInvokeStatic(ir.InvokeStatic exp) {
+ addEdgeToContinuation(exp.continuation);
+ }
+
visitInvokeMethod(ir.InvokeMethod exp) {
- ir.Definition target = exp.continuation.definition;
- if (target is ir.Continuation && target.body != null) {
- current_block.addEdgeTo(getBlock(target));
- }
+ addEdgeToContinuation(exp.continuation);
}
visitInvokeConstructor(ir.InvokeConstructor exp) {
- ir.Definition target = exp.continuation.definition;
- if (target is ir.Continuation && target.body != null) {
- current_block.addEdgeTo(getBlock(target));
- }
+ addEdgeToContinuation(exp.continuation);
}
visitConcatenateStrings(ir.ConcatenateStrings exp) {
- ir.Definition target = exp.continuation.definition;
- if (target is ir.Continuation && target.body != null) {
- current_block.addEdgeTo(getBlock(target));
- }
+ addEdgeToContinuation(exp.continuation);
}
visitInvokeContinuation(ir.InvokeContinuation exp) {
- ir.Definition target = exp.continuation.definition;
- if (target is ir.Continuation && target.body != null) {
- current_block.addEdgeTo(getBlock(target));
- }
+ addEdgeToContinuation(exp.continuation);
+ }
+
+ visitSetClosureVariable(ir.SetClosureVariable exp) {
+ visit(exp.body);
+ }
+
+ visitDeclareFunction(ir.DeclareFunction exp) {
+ visit(exp.body);
}
visitBranch(ir.Branch exp) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart ('k') | tests/compiler/dart2js/dart_printer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698