Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 366853003: [ServiceWorker] A header list contains lowercased header names (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
Reviewers:
falken, yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : quote #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -41 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/headers-worker.js View 6 chunks +26 lines, -26 lines 0 comments Download
M Source/modules/serviceworkers/FetchHeaderList.cpp View 1 7 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
horo
yhirano@ Could you please review?
6 years, 5 months ago (2014-07-02 04:38:20 UTC) #1
yhirano
lgtm
6 years, 5 months ago (2014-07-02 05:49:42 UTC) #2
horo
falken@ Could you please review?
6 years, 5 months ago (2014-07-02 06:28:28 UTC) #3
falken
lgtm https://codereview.chromium.org/366853003/diff/1/Source/modules/serviceworkers/FetchHeaderList.cpp File Source/modules/serviceworkers/FetchHeaderList.cpp (right): https://codereview.chromium.org/366853003/diff/1/Source/modules/serviceworkers/FetchHeaderList.cpp#newcode69 Source/modules/serviceworkers/FetchHeaderList.cpp:69: // whose name is |name|, byte lowercased, from ...
6 years, 5 months ago (2014-07-02 08:12:12 UTC) #4
horo
https://codereview.chromium.org/366853003/diff/1/Source/modules/serviceworkers/FetchHeaderList.cpp File Source/modules/serviceworkers/FetchHeaderList.cpp (right): https://codereview.chromium.org/366853003/diff/1/Source/modules/serviceworkers/FetchHeaderList.cpp#newcode69 Source/modules/serviceworkers/FetchHeaderList.cpp:69: // whose name is |name|, byte lowercased, from |list|. ...
6 years, 5 months ago (2014-07-02 08:42:46 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-02 08:43:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/366853003/20001
6 years, 5 months ago (2014-07-02 08:43:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 09:57:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 10:38:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15034)
6 years, 5 months ago (2014-07-02 10:38:13 UTC) #10
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-02 11:07:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/366853003/20001
6 years, 5 months ago (2014-07-02 11:08:07 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:14:15 UTC) #13
Message was sent while issue was closed.
Change committed as 177377

Powered by Google App Engine
This is Rietveld 408576698