Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 366843002: Add following helper methods to track successful QUIC client port migrations: (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Added following helper methods to track successful QUIC client port migrations: + peer_port_changed() + received_packet_manager() + sequence_number_of_last_sent_packet() + largest_observed() The following is the original internal CL description: Add two varz to track successful QUIC client port migrations: peer_port_changes -- Number of times we have seen the peer's port change mid-connection. successful_peer_port_migrations -- Successful connection migrations to a new peer port. Add varz to track successful QUIC client port migrations. Protected behind existing, enabled, FLAGS_..._quic_allow_port_migration. Merge internal change: 70318257 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M net/quic/quic_connection.h View 2 chunks +11 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_client_peer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_client_peer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-07-02 01:47:53 UTC) #1
Ryan Hamilton
lgtm Might want to tailor the CL description to match the piece of the CL ...
6 years, 5 months ago (2014-07-02 19:23:47 UTC) #2
ramant (doing other things)
6 years, 5 months ago (2014-07-02 19:34:20 UTC) #3
On 2014/07/02 19:23:47, Ryan Hamilton wrote:
> lgtm
> 
> Might want to tailor the CL description to match the piece of the CL which is
> landing in Chrome.

Thanks Ryan. Updated the description in this CL and the Landing Recent QUIC
changes CL.

Powered by Google App Engine
This is Rietveld 408576698