Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 366813006: DevTools: DataGrid: add ability to insert row in sorted tables. (Closed)

Created:
6 years, 5 months ago by eustas
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: DataGrid: add ability to insert row in sorted tables. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/devtools/front_end/ui/DataGrid.js View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eustas
6 years, 5 months ago (2014-07-02 16:14:26 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-02 16:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/366813006/1
6 years, 5 months ago (2014-07-02 16:23:39 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 17:42:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 18:25:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15115)
6 years, 5 months ago (2014-07-02 18:25:31 UTC) #6
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 5 months ago (2014-07-02 19:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/366813006/1
6 years, 5 months ago (2014-07-02 19:11:07 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 19:40:17 UTC) #9
Message was sent while issue was closed. 
Change committed as 177413

Powered by Google App Engine
This is Rietveld 408576698