Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 366763003: Only build the x86 arches we actually need. (Closed)

Created:
6 years, 5 months ago by bradn
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Only build the x86 arches we actually need. BUG=https://code.google.com/p/chromium/issues/detail?id=388101 TEST=trybots

Patch Set 1 : fix #

Total comments: 3

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -65 lines) Patch
M build/nacl_core_sdk.gyp View 1 2 3 chunks +15 lines, -9 lines 0 comments Download
M build/untrusted.gypi View 1 2 3 11 chunks +69 lines, -53 lines 0 comments Download
M tools.gyp View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
6 years, 5 months ago (2014-07-02 18:29:56 UTC) #1
binji
looks good in general, though I'd want to make sure that the NaCl SDK build ...
6 years, 5 months ago (2014-07-02 18:49:10 UTC) #2
Mark Seaborn
Please fill out BUG= https://code.google.com/p/chromium/issues/detail?id=388101
6 years, 5 months ago (2014-07-02 18:58:30 UTC) #3
jam
Thanks for working on this. Mac is still 32 bit though, so don't we also ...
6 years, 5 months ago (2014-07-02 20:49:19 UTC) #4
jam
ping?
6 years, 5 months ago (2014-07-22 17:12:02 UTC) #5
Mark Seaborn
6 years, 5 months ago (2014-07-22 17:40:27 UTC) #6
"TEST=trybots" is not really enough testing.  Can you do Chromium trybot runs
for this change, using clobber builds, please?

https://codereview.chromium.org/366763003/diff/120001/build/untrusted.gypi
File build/untrusted.gypi (right):

https://codereview.chromium.org/366763003/diff/120001/build/untrusted.gypi#ne...
build/untrusted.gypi:369: ['target_arch=="ia32" or (target_arch=="x64" and
OS=="win")', {
64-bit Windows Chrome builds don't need to include x86-32 nexes, AFAIK.

https://codereview.chromium.org/366763003/diff/120001/build/untrusted.gypi#ne...
build/untrusted.gypi:1566: ['target_arch=="ia32" or target_arch=="x64"', {
What about this one?

To avoid duplication, can we define some "build for x86_32" and "build for
x86_64" variables in a single place?

Powered by Google App Engine
This is Rietveld 408576698