Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 366723002: Disable all ActivityLogger tests, they're flaky (Closed)

Created:
6 years, 5 months ago by pmarch
Modified:
6 years, 5 months ago
Reviewers:
haraken, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Disable all ActivityLogger tests, they're flaky These caused the last Blink roll to be reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=280864 NOTRY=true BUG=388287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177340

Patch Set 1 #

Patch Set 2 : all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M Source/web/tests/ActivityLoggerTest.cpp View 1 15 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pmarch
Eric, please, review.
6 years, 5 months ago (2014-07-01 20:45:18 UTC) #1
eseidel
lgtm I would just disable all of these which use data: urls, since I don't ...
6 years, 5 months ago (2014-07-01 21:05:29 UTC) #2
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 5 months ago (2014-07-01 21:30:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/366723002/20001
6 years, 5 months ago (2014-07-01 21:32:20 UTC) #4
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 5 months ago (2014-07-01 21:44:27 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 5 months ago (2014-07-01 21:44:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/366723002/20001
6 years, 5 months ago (2014-07-01 21:44:38 UTC) #7
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 5 months ago (2014-07-01 21:45:03 UTC) #8
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 5 months ago (2014-07-01 21:45:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/366723002/20001
6 years, 5 months ago (2014-07-01 21:45:07 UTC) #10
haraken
LGTM.
6 years, 5 months ago (2014-07-01 23:26:04 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 23:55:06 UTC) #12
Message was sent while issue was closed.
Change committed as 177340

Powered by Google App Engine
This is Rietveld 408576698