Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 366703005: Remove outdated FIXME comment from Document::decrementActiveParserCount() (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove outdated FIXME comment from Document::decrementActiveParserCount() Remove outdated FIXME comment from Document::decrementActiveParserCount(). This comment was added by Eric in http://trac.webkit.org/changeset/143753 and was associated to the #if ENABLE(THREADED_HTML_PARSER) check. However, those checks were removed in Blink at: https://src.chromium.org/viewvc/blink?revision=148736&view=revision As a result, the comment no longer makes sense as it is already "always enabled". The same comment in DocumentLoader.cpp was correctly removed with the THREADED_HTML_PARSER defined, only the one in Document.cpp remained. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 5 months ago (2014-07-01 21:06:26 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-07-01 21:24:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/366703005/1
6 years, 5 months ago (2014-07-01 21:25:07 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 23:53:51 UTC) #4
Message was sent while issue was closed.
Change committed as 177339

Powered by Google App Engine
This is Rietveld 408576698